Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pull down to refresh #1086

Merged
merged 5 commits into from
Feb 1, 2024
Merged

Conversation

GianniCarlo
Copy link
Collaborator

Purpose

  • Add pull down to refresh to:
    • Scan local files in case there's something pending import
    • Fetch remote data

Related tasks

#1074

Approach

  • Add refresh control to the table view
  • Rework fetching the data and the last played book update into a separate service
  • Use new service to be reused between the coordinators and the item list view model

Things to be aware of / Things to focus on

  • There was a bug introduced by setting the flag withIntermediateDirectories to true when creating a folder on disk, this would make the FileManager not throw an error if there was already a folder with the exact name

@GianniCarlo GianniCarlo self-assigned this Feb 1, 2024
@GianniCarlo GianniCarlo merged commit 6bb9c72 into develop Feb 1, 2024
1 check passed
@GianniCarlo GianniCarlo deleted the pull-down-to-refresh branch February 1, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant