Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix review nits for json_io #406

Merged
merged 1 commit into from
Feb 14, 2025
Merged

fix review nits for json_io #406

merged 1 commit into from
Feb 14, 2025

Conversation

jmoggr
Copy link
Collaborator

@jmoggr jmoggr commented Feb 14, 2025

No description provided.

@jmoggr jmoggr requested a review from KevinDCarlson February 14, 2025 16:01
@jmoggr jmoggr changed the title json_io review nits fix review nits for json_io Feb 14, 2025
@jmoggr jmoggr mentioned this pull request Feb 14, 2025
Merged
@github-actions GitHub Actions
Copy link

Preview url: https://67af69503fdff00073e02101--catcolab.netlify.app

KevinDCarlson
KevinDCarlson approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@KevinDCarlson KevinDCarlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Jason! I believe I understand everything here; streamlining the error handling was particularly helpful.

@KevinDCarlson KevinDCarlson merged commit 762bf6f into json_io Feb 14, 2025
10 checks passed
@KevinDCarlson KevinDCarlson deleted the json_io-review-nits branch February 14, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinDCarlson KevinDCarlson KevinDCarlson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmoggr @KevinDCarlson