OBEE-32: integrate instances - #1415
Open
tslil-topos wants to merge 1 commit into
Open
Conversation
tslil-topos
added
enhancement
Notion Integration |
tslil-topos
commented
Aug 21, 2026
| const document = InstanceMethods.newInstanceDocument({ | ||
| _id: schemaRef.id, | ||
| _version: schemaRef.version, | ||
| _server: schemaRef.server ?? "", |
Collaborator
Author
There was a problem hiding this comment.
not sure what to do here
Collaborator
Author
There was a problem hiding this comment.
schemaRef.server ?? "", it's unclear to me what the default should be
kasbah
reviewed
Aug 21, 2026
| } | ||
|
|
||
| export interface Notebook<S extends Shape, D extends NotebookDocument = NotebookDocument> { | ||
| export interface Notebook<H, S extends Shape, D extends NotebookDocument = NotebookDocument> { |
Member
There was a problem hiding this comment.
Offline I suggested this:
Suggested change
| export interface Notebook<H, S extends Shape, D extends NotebookDocument = NotebookDocument> { | |
| export interface Notebook<S extends Shape, D extends NotebookDocument = NotebookDocument, H = unknown> { |
Collaborator
Author
There was a problem hiding this comment.
this is a minor aesthetic change, we can discuss its merits separately to this stacked pr, open an issue, or otherwise revisit it when there are less pressing things to attend to. If there are no other concerns please approve this change.
tslil-topos
force-pushed
the
tslil/instance_wiring
branch
from
August 21, 2026 14:58
98752da to
ccf37de
Compare
*tests will come at the end of this commit stack* This change exposes store handles on notebooks so that binders can validate schemas and form instance-of links before creating instances. This allows us to make creating instances actually possible for the first time in this stack. Propagate the notebook handle type through existing consumers.
tslil-topos
force-pushed
the
tslil/instance_wiring
branch
from
August 24, 2026 13:24
ccf37de to
1c6c500
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests will come at the end of this commit stack
This change exposes store handles on notebooks so that binders can validate schemas and form instance-of links before creating instances. This allows us to make creating instances actually possible for the first time in this stack.
Propagate the notebook handle type through existing consumers.