Skip to content

investigate deps #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from

Conversation

error-four-o-four
Copy link
Contributor

@error-four-o-four error-four-o-four commented May 27, 2025

  1. Please make all pull requests on the dev branch. ✅
  2. Don't commit build files ✅
  3. Try to get all tests to pass. ✅

Hey there,

as already mentioned I began to migrate dependencies fs-extra, glob, rimraf

Additionally .mjs and .cjs files were included in the linter config. FYI: simple-sort-import does not work with commonJS files (link). This could be a reason to migrate the scripts. I'd be happy to update this PR and implement this change if you're interested.

I didn't investigate other dependencies yet but npmgraph provides a good entrypoint to do so.

A few other things that caught my attention but aren't implemented yet:

  • The npm script docs fails because scripts/generate_docs.cjs does not exist (has issue)
  • I recently switched from windows to WSL/Ubuntu and had to explicitly set executablePath to make puppeteer happy and successfully run the tests (I think this has a very low priority)
  • Could you please elaborate why tslib is included as a dependency? I guess it's because the .ts files are also included via the field files in package.json, right?

Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.95%. Comparing base (2626e0a) to head (84b2e2d).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1348   +/-   ##
=======================================
  Coverage   98.95%   98.95%           
=======================================
  Files         203      203           
  Lines       22725    22725           
  Branches      996      997    +1     
=======================================
  Hits        22487    22487           
  Misses        237      237           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@error-four-o-four
Copy link
Contributor Author

error-four-o-four commented May 29, 2025

closes #1339

Oh dear.

After all this PR reduces the following stats:

  • Amount of dependencies (including devDependencies): 927 => 904
  • Modules with multiple versions: 80 => 78
  • Deprecated Modules: 10 => 3

but there are still a few things to do:

@rollup/plugin-commonjs
@types/chai
@types/mocha
codecov
concurrently
http-server
plotly.js-dist
semver
typedoc
ua-parser-js
webpack-cli
yargs

When using @rollup/plugin-commonjs >=27 the tests fail because external modules can't be resolved. I've tried to add "allowSyntheticDefaultImports": true to the compiler options but without any success. I'd have to investigate the webpack bundle process and tools a bit further. At the moment I'm very tempted to migrate to vite and vitest but I don't know if this is a viable option (esp. in regard to the workflows of @tonejs/ui and tonejs.github.io) but not today.

@error-four-o-four error-four-o-four marked this pull request as ready for review May 29, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant