-
Notifications
You must be signed in to change notification settings - Fork 1k
investigate deps #1348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
investigate deps #1348
Conversation
… directory removal
…for improved file handling
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1348 +/- ##
=======================================
Coverage 98.95% 98.95%
=======================================
Files 203 203
Lines 22725 22725
Branches 996 997 +1
=======================================
Hits 22487 22487
Misses 237 237
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
closes #1339 Oh dear. After all this PR reduces the following stats:
but there are still a few things to do: @rollup/plugin-commonjs When using |
dev
branch. ✅Hey there,
as already mentioned I began to migrate dependencies
fs-extra
,glob
,rimraf
Additionally .mjs and .cjs files were included in the linter config. FYI:
simple-sort-import
does not work with commonJS files (link). This could be a reason to migrate the scripts. I'd be happy to update this PR and implement this change if you're interested.I didn't investigate other dependencies yet but npmgraph provides a good entrypoint to do so.
A few other things that caught my attention but aren't implemented yet:
The npm script(has issue)docs
fails becausescripts/generate_docs.cjs
does not existexecutablePath
to make puppeteer happy and successfully run the tests (I think this has a very low priority)Could you please elaborate whytslib
is included as a dependency? I guess it's because the .ts files are also included via the fieldfiles
inpackage.json
, right?