Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: warn and exclude lights with no flats, fix prepare command when no filter used #42

Merged

Conversation

TomyCesaille
Copy link
Owner

@TomyCesaille TomyCesaille commented Feb 8, 2025

Description

  • Warn if there's lights with no flats matching
  • exclude them, if any, from the rest of the pipeline (poto-siril is pointless without flats)
  • bug fix a few stuff around layers with no filter
    • improve e2e test coverage around this

Related Issue

Closes #41

Type of change

  • Chore
  • Bug fix
  • New feature
  • Feature change
  • Breaking change
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.81%. Comparing base (a637bb0) to head (135089e).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   94.33%   94.81%   +0.48%     
==========================================
  Files           7        7              
  Lines         600      617      +17     
  Branches      151      162      +11     
==========================================
+ Hits          566      585      +19     
+ Misses         33       31       -2     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TomyCesaille TomyCesaille merged commit d4f44ce into main Feb 8, 2025
11 checks passed
@TomyCesaille TomyCesaille deleted the feature/lightswithnomatchingflatsareleftbehind#41 branch February 8, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lights with no matching flats are left behind
1 participant