-
-
Notifications
You must be signed in to change notification settings - Fork 103
Fixes quotation marks in titles on /transfer #1335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. can u test it please?
maybe temporarily edit the line above to inject a bad title like String title = "\"Hello\""; and then use /transfer in your local test server to verify it works as expected.
You can then send a screenshot here and if its good we can merge it 👍
(btw, you need to learn to improve your PR titles and descriptions a bit. Ive added the bare minimum for you now.)
Of course. Yea im working on it.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thanks 👍
|
Hi, is there something i should do for this to be merged or just wait for approval? |
|
@Bobi222 usually our rule is "2 approvals or 1 approval plus a week". so ill just merge it now - thanks a lot 😃 |
|
Thank you too! :) |


Fixes and closes #1134