Skip to content

Conversation

alexander-schranz
Copy link
Contributor

@alexander-schranz alexander-schranz commented Sep 22, 2025

Test current compatibility to Symfony 8.

Is required: FriendsOfSymfony/FOSHttpCache#597 as CI installs this package.

@alexander-schranz
Copy link
Contributor Author

@Toflar CI seems currently be disabled. Github is doing this because there where not any changes and disable CI with schedules after 1-2 month:

schedule:
- cron: 0 13 * * MON

You should be able reactivate it in: https://github.com/Toflar/psr6-symfony-http-cache-store/actions

@Toflar
Copy link
Owner

Toflar commented Sep 23, 2025

Re-enabled, I guess you need to push again to trigger CI?

@alexander-schranz
Copy link
Contributor Author

alexander-schranz commented Sep 26, 2025

@Toflar how would you handle the deprecation errors on lowest? As I added PHP 8.4:

Lot of Implicitly marking parameter like are shown:

Implicitly marking parameter $value as nullable is deprecated, the explicit nullable type must be used instead

@Toflar
Copy link
Owner

Toflar commented Sep 27, 2025

I guess that's a wrong configuration of phpunit because those are not deprecations we can influence, are they? So update the phpunit configuration, maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants