Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable join message delay #14

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

addstar
Copy link

@addstar addstar commented Mar 5, 2024

This is just a simple change to allow the join message delay to be configurable.

By default, everything will remain the same for existing users, it should add the default value of 3 into the config.yml. I'm currently running this on my own network and it's working great.

I understand the concerns and hesitations discussed in #8 but I think there are scenarios (like ours) where we would rather have a more timely join message than a possible false one from a ban. We use proxy based bans (not relying on server bans) and players are refused almost immediately, even 1s is more than enough time to validate the player is connected.

@holli2801
Copy link

I love this, thanks for adding it, lets hope it can be added quickly. Or is there another way to get this before?

@EarthCow
Copy link

EarthCow commented Apr 1, 2024

@holli2801 If you haven't built this yet I just built it today for myself here: BungeeJoinMessages-1.12.0.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants