Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a simple change to allow the join message delay to be configurable.
By default, everything will remain the same for existing users, it should add the default value of
3
into theconfig.yml
. I'm currently running this on my own network and it's working great.I understand the concerns and hesitations discussed in #8 but I think there are scenarios (like ours) where we would rather have a more timely join message than a possible false one from a ban. We use proxy based bans (not relying on server bans) and players are refused almost immediately, even 1s is more than enough time to validate the player is connected.