fixed owner null bug #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What does this solve? |
johankson
reviewed
Nov 27, 2022
| { | ||
| try | ||
| { | ||
| if (subscription.Owner.Target == null) |
There was a problem hiding this comment.
Why doesn't just
subscriber.Owner?.Target == null
be enough? Instead of creating a static object? Just trying to understand.
There was a problem hiding this comment.
Nope, then it will think the owner is collected by GC. Maybe we should deprecate the method of not having an owner?
johankson
reviewed
Nov 27, 2022
| if (subscription.Owner.Target == null) | ||
| { | ||
| subscriptionsToRemove.Add(subscription); | ||
| continue; |
There was a problem hiding this comment.
Why continue here? What happens if ActionWithArgumentAndArgs isn't null? Then it will not be called?
There was a problem hiding this comment.
Because if it is null the object owning it is been collected by GC. And then we can remove that subscription
|
Missing unit-tests to verify the old and new logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.