chore: Validate accountId can be resolved - #2589
Open
cristianonicolai wants to merge 1 commit into
Open
Conversation
cristianonicolai
requested review from
TomCools,
rsynek and
triceo
as code owners
August 13, 2026 02:32
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens the Maven plugin’s configure goal behavior to ensure a Timefold Platform accountId can always be resolved (explicitly configured or unambiguously derived from the /aboutme response), failing the build when it cannot.
Changes:
- Introduce
ConfigureMojo.resolveAccountId(...)to centralize account-id resolution and fail fast on missing/ambiguous account associations. - Add new WireMock-backed tests covering: token with no accounts, platform response missing
accountIds, and token associated with multiple accounts (including the explicit override case). - Document the stricter failure behavior in the plugin README.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| service/tools/maven-plugin/src/main/java/ai/timefold/solver/tools/maven/ConfigureMojo.java | Adds explicit accountId resolution logic and failure modes for empty/ambiguous platform account association. |
| service/tools/maven-plugin/src/test/java/ai/timefold/solver/tools/maven/ConfigureMojoTest.java | Adds test coverage for the new accountId resolution failure/success scenarios. |
| service/tools/maven-plugin/README.adoc | Documents the new “fail when accountId can’t be resolved” behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.