fix(identity): add opencloud.ldap.keepIdm for external OIDC without OpenLDAP - #169
Merged
Merged
Conversation
Allow external OIDC with bundled IDM (keepIdm: true) while keeping external OpenLDAP the default (keepIdm: false). Fail on the invalid keepIdm + excluded idm combination. Supported external-LDAP layout excludes idp and idm.
Owner
|
@suse-coder rdy to merge? |
Author
|
yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on and supersedes #167 (thanks @HttpRafa for the original work).
I checked PR #167 on a real cluster (external Keycloak, Flux) and it works. This takes the same approach with some smaller changes and fixes:
opencloud.ldap.keepIdm(defaultfalse):excludeServices: [idp]keeps pointingOC_LDAP_*at OpenLDAP — existing installs unaffected. SetkeepIdm: true(and do not excludeidm) to keep accounts in the bundled IDM with external OIDC.keepIdmis validated underopencloud.ldap(PR fix(identity): add opencloud.ldap.keepIdm for external OIDC without OpenLDAP #167 placed it underfeatures.externalUserManagement.ldap, where it validated nothing and the real value went unchecked).keepIdm: true+ excludedidmnow fails fast with a clear message instead of rendering a deployment with no user directory.deployments/flux/opencloud/opencloud.yaml) now excludesidp+idmfor the supported external-LDAP layout.secretRef, bundled IDM binds from init secret, invalid-combo failure); fixed the pre-existing httpOC_URLtest which never disabledglobal.tls.external.keepIdmselects the directory (no user migration).CONTRIBUTING.md: documented requiredhelm lint --strict+helm unittestvalidation.Verified:
helm lint --strict,helm templatefor all LDAP combinations,openldap_test.yaml20/20 pass, Flux reconcile of the branch on a live cluster.