Do not use read-ahead cache in array/group directory. #5452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In all cases where we read files from the VFS there, we get the file's size beforehand and read the entirety of it. This makes the read-ahead cache not actually required. Fixes failures when reading empty `.vac` files.
ypatia
approved these changes
Feb 13, 2025
ihnorton
pushed a commit
that referenced
this pull request
Feb 18, 2025
[SC-62900](https://app.shortcut.com/tiledb-inc/story/62900) In all cases where we read files from the VFS there, we get the file's size beforehand and read the entirety of it. This makes the read-ahead cache not actually required. Fixes failures when reading empty `.vac` files (in S3 we do a `GetObject` with a range of `0-102399`, which fails with a range not satisfiable error). --- TYPE: BUG DESC: Fix failures when opening an array or group with an empty `.vac` file. (cherry picked from commit ab6c52e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-62900
In all cases where we read files from the VFS there, we get the file's size beforehand and read the entirety of it. This makes the read-ahead cache not actually required.
Fixes failures when reading empty
.vacfiles (in S3 we do aGetObjectwith a range of0-102399, which fails with a range not satisfiable error).TYPE: BUG
DESC: Fix failures when opening an array or group with an empty
.vacfile.