Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-2.27] Rr/sc 60366 sparse global order reader merge (#5417) #5443

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 10, 2025

Backport of #5417 to release-2.27


TYPE: IMPROVEMENT
DESC: sparse global order reader determine global order of result tiles

ihnorton pushed a commit that referenced this pull request Feb 10, 2025
…5417) (#5443)

Backport of #5417 to release-2.27

---

Sc-60366

Implements "pre-process tile order" mode for the sparse global order reader.
In brief, this does a first pass over the fragment metadata tile MBRs
to create a single unified list of all the (fragment ID, tile ID) pairs arranged
approximately in global order.

When running natively, the tile order is computed a single time the first
time the query is submitted, and then kept in memory.  When running
on the REST server, the tile order is recomputed for each query message.
Evidence indicates that the overhead of this is low; we expect that it is
lower than serializing the tile order would be.

- Add parallel merge algorithm
- Add rapidcheck library and some common scaffolding code
- Add `tiledb_submit_a_b` performance testing binary
- Add preprocess tile order mode to sparse global order reader, on by default

---
TYPE: FEATURE | BUG | IMPROVEMENT
DESC: sparse global order reader determine global order of result tiles

(cherry picked from commit 3c617e3)
@ihnorton ihnorton force-pushed the backport/pr-5417-to-release-2.27 branch from a0da024 to a4e68e5 Compare February 10, 2025 22:18
@teo-tsirpanis teo-tsirpanis changed the base branch from release-2.27 to backport/pr-5391-to-release-2.27 February 11, 2025 11:52
@teo-tsirpanis teo-tsirpanis reopened this Feb 11, 2025
@teo-tsirpanis teo-tsirpanis reopened this Feb 11, 2025
…5417) (#5443)

Backport of #5417 to release-2.27

---

Sc-60366

Implements "pre-process tile order" mode for the sparse global order reader.
In brief, this does a first pass over the fragment metadata tile MBRs
to create a single unified list of all the (fragment ID, tile ID) pairs arranged
approximately in global order.

When running natively, the tile order is computed a single time the first
time the query is submitted, and then kept in memory.  When running
on the REST server, the tile order is recomputed for each query message.
Evidence indicates that the overhead of this is low; we expect that it is
lower than serializing the tile order would be.

- Add parallel merge algorithm
- Add rapidcheck library and some common scaffolding code
- Add `tiledb_submit_a_b` performance testing binary
- Add preprocess tile order mode to sparse global order reader, on by default

---
TYPE: FEATURE | BUG | IMPROVEMENT
DESC: sparse global order reader determine global order of result tiles

(cherry picked from commit 3c617e3)
@teo-tsirpanis teo-tsirpanis force-pushed the backport/pr-5417-to-release-2.27 branch from a4e68e5 to 1459f76 Compare February 11, 2025 13:45
Copy link
Member

@teo-tsirpanis teo-tsirpanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can merge once #5444 gets merged.

Base automatically changed from backport/pr-5391-to-release-2.27 to release-2.27 February 11, 2025 15:55
@teo-tsirpanis teo-tsirpanis changed the base branch from release-2.27 to backport/pr-5419-to-release-2.27 February 12, 2025 12:06
@teo-tsirpanis teo-tsirpanis merged commit 4bc25ea into backport/pr-5419-to-release-2.27 Feb 12, 2025
7 checks passed
@teo-tsirpanis teo-tsirpanis deleted the backport/pr-5417-to-release-2.27 branch February 12, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants