[DEVEXP] Upgrade PHP 7.4 #12
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PHP CLI Dockerfile has been simplified by merging apt-get instructions and removing unnecessary and unused resources such as the mailhog client, nodejs, and awscli.
The changes include updating various composer dependencies to newer versions and modifying scripts in composer.json. Adjustments were also made to PHPUnit configuration file and the new dependencies were added to composer.lock for version tracking.
The .gitignore file has been updated to include new files and folders that need to be ignored by Git. This includes system-specific files like .DS_Store, tooling output like .phpunit.result.cache, and the vendor/ directory to maintain the codebase clean and focused on source files.
This update establishes a Rector configuration, and sets up a Docker container for PHP Rector. The Rector configuration is designed to ensure strict types and includes paths for source code and test files. The Docker container includes PHP 7.4 and Composer, with the Rector dependency installed.
Add return types to test methods and use null coalescing assignment
The Docker commands in the GitHub workflow file have been updated from "docker-compose" to "docker compose". This is reflected in the lines for checking code style, installing dependencies, and running the test suite. This change ensures compatibility with newer Docker versions where "docker compose" is the recommended syntax.
juanariastn
changed the title
In the docker-compose YAML file for the CLI, the PHP CS Fixer image has been updated to use the latest tag for PHP 7.4 instead of PHP 7.0.
The command for "Check code style" in the php.yml workflow file has been adjusted. The obsolete `--show-progress=estimating` argument has been removed from the php-cs-fixer fix command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
rectortool to analyse and detect PHP version updatesHelpful commands
Unit tests
Rector