-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - converting to OpenCL - 1 test #3
Open
kalwalt
wants to merge
17
commits into
ThorstenBux:master
Choose a base branch
from
kalwalt:feature-test-OpenCL
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
1e8dde0
convert cv::Mat to cv::UMat, not finished
kalwalt 67527bf
last cv::MAt to cv::UMat translation
kalwalt 04b6592
this fix the issue inside ProcessFrameData() - only for EMSCRIPTEN
kalwalt 746a87b
UMat in FeatureDetector
kalwalt d5de60d
UMat for HarrisDetector
kalwalt 201b12f
addMarker needs to copy the image
kalwalt 4ef2829
UMat conversion for DetectAndCompute inside AddMarker
kalwalt 622cb01
trying to convert the shared pointer
kalwalt 41fe28e
commenting te save and load images, for a succesfull build!
kalwalt 74ddef1
passing the data correctly now
kalwalt 42f379e
simpler passing of data to convert to gray
kalwalt aaa4c77
image restored in Load and SaveDatabase
kalwalt 5b7fe39
adding Umat in minMaxLoc
kalwalt 108358c
better ProcessFrameData
kalwalt 7321c4e
better ProcessFrameData
kalwalt 5cb8794
Merge branch 'feature-test-OpenCL' of https://github.com/kalwalt/arto…
kalwalt 42ca820
convert to UMat at the end
kalwalt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -721,7 +721,10 @@ class PlanarTracker::PlanarTrackerImpl | |
info.fileName = _trackables[i]._fileName; | ||
// Copy the image data and use a shared_ptr to refer to it. | ||
unsigned char *data = (unsigned char *)malloc(_trackables[i]._width * _trackables[i]._height); | ||
memcpy(data, _trackables[i]._image.ptr(), _trackables[i]._width * _trackables[i]._height); | ||
/// this needs to be verifyed!! | ||
cv::Mat dataPtr(_trackables[i]._width, _trackables[i]._height, CV_8UC4, data); | ||
_trackables[i]._image = dataPtr.getUMat(cv::ACCESS_READ); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we should do the reverse!, we will have to fill in the data from the trackables to image data, so it doesn't work |
||
//memcpy(data, _trackables[i]._image.ptr(), _trackables[i]._width * _trackables[i]._height); | ||
info.imageData.reset(data, free); | ||
info.width = _trackables[i]._width; | ||
info.height = _trackables[i]._height; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is only a test, completely not sure of.