Improve quota handling, add tests, refactor#47
Merged
rustybee42 merged 6 commits intomainfrom Feb 13, 2026
Merged
Conversation
rustybee42
force-pushed
the
rb/quota-usage-fix
branch
from
7ec4281 to
b0e16e5
Compare
rustybee42
force-pushed
the
rb/quota-usage-fix
branch
2 times, most recently
from
ba7f4d2 to
5763d97
Compare
rustybee42
force-pushed
the
rb/quota-usage-fix
branch
from
5763d97 to
857403a
Compare
rustybee42
changed the title
rustybee42
force-pushed
the
rb/quota-usage-fix
branch
4 times, most recently
from
08060f7 to
14a431e
Compare
rustybee42
force-pushed
the
rb/quota-usage-fix
branch
from
14a431e to
1dfea75
Compare
philippfalk
previously approved these changes
Feb 13, 2026
Member
philippfalk
left a comment
philippfalk
left a comment
There was a problem hiding this comment.
Looks good. I just had a couple of questions for clarification. I focused my review most on the functional changes in this PR and put less effort into reviewing the tests.
rustybee42
force-pushed
the
rb/quota-usage-fix
branch
from
1dfea75 to
bfa98e6
Compare
We want to get rid of them over time and rather put sql directly into
the handlers instead of having unnecessary abstractions ("db layer").
With the quota usage fix, this is a good opportunity to do so.
Clone and Default are now part of Msg, while the rest of the requirements in on BaseMsg. This allows creating trait objects from BaseMsg, which is required to implement the TestApp mock request handler.
rustybee42
force-pushed
the
rb/quota-usage-fix
branch
from
bfa98e6 to
9d0bf02
Compare
philippfalk
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.