test(questionTool): add parser coverage and reject unsupported fields

src/main/lib/agentRuntime/questionTool.ts

@@ -59,6 +59,7 @@ export const questionToolSchema = z
         'Whether free-form input is allowed for this question. The field name is `custom`, not `allowOther`.'
       )
   })
+  .strict()
   .describe(
     'Ask exactly one blocking clarification question. For multiple clarifications, use multiple deepchat_question tool calls instead of sending a `questions` array.'
   )

test/main/lib/agentRuntime/questionTool.test.ts

@@ -0,0 +1,89 @@
+import { describe, expect, it } from 'vitest'
+import {
+  parseQuestionToolArgs,
+  QUESTION_TOOL_CONTRACT_HINT,
+  QUESTION_TOOL_NAME
+} from '../../../../src/main/lib/agentRuntime/questionTool'
+
+describe('parseQuestionToolArgs', () => {
+  it('normalizes valid question tool arguments and applies defaults', () => {
+    const result = parseQuestionToolArgs(
+      JSON.stringify({
+        header: '  Clarify  ',
+        question: '  Which option should we use?  ',
+        options: [
+          { label: '  Option A  ', description: '  First choice  ' },
+          { label: 'Option B', description: '   ' }
+        ]
+      })
+    )
+
+    expect(result).toEqual({
+      success: true,
+      data: {
+        header: 'Clarify',
+        question: 'Which option should we use?',
+        options: [{ label: 'Option A', description: 'First choice' }, { label: 'Option B' }],
+        multiple: false,
+        custom: true
+      }
+    })
+  })
+
+  it('repairs recoverable JSON before validation', () => {
+    const result = parseQuestionToolArgs(
+      '{"question":"Pick one","options":[{"label":"A","description":"  Alpha  ",},],}'
+    )
+
+    expect(result).toEqual({
+      success: true,
+      data: {
+        question: 'Pick one',
+        options: [{ label: 'A', description: 'Alpha' }],
+        multiple: false,
+        custom: true
+      }
+    })
+  })
+
+  it('returns a contract hint when the JSON is not parseable', () => {
+    expect(parseQuestionToolArgs('{"question":"\\uZZZZ"}')).toEqual({
+      success: false,
+      error: `Invalid JSON for question tool arguments. ${QUESTION_TOOL_CONTRACT_HINT}`
+    })
+  })
+
+  it('rejects unsupported top-level fields even when required fields are present', () => {
+    const cases = [
+      {
+        fieldName: 'allowOther',
+        payload: {
+          question: 'Pick one',
+          options: [{ label: 'A' }],
+          allowOther: true
+        }
+      },
+      {
+        fieldName: 'questions',
+        payload: {
+          question: 'Pick one',
+          options: [{ label: 'A' }],
+          questions: [{ question: 'Nested', options: [{ label: 'B' }] }]
+        }
+      }
+    ] as const
+
+    for (const testCase of cases) {
+      const result = parseQuestionToolArgs(JSON.stringify(testCase.payload))
+
+      expect(result.success).toBe(false)
+      if (result.success) {
+        throw new Error(`Expected ${testCase.fieldName} payload to be rejected`)
+      }
+
+      expect(result.error).toContain(`Invalid arguments for ${QUESTION_TOOL_NAME}.`)
+      expect(result.error).toContain(QUESTION_TOOL_CONTRACT_HINT)
+      expect(result.error).toContain(testCase.fieldName)
+    }
+  })
+})