도메인 주도 설계란 무엇인가? 1주차 - 이동현 #508
Conversation
dhlee3994
requested review from
jongfeel,
TaeHyoungKwon,
jintaeyeong,
hemil0102,
ymkim97,
aquamagic9,
fkdl0048 and
tttghost
|
우측에 있는 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @dhlee3994, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request by dhlee3994 adds a summary of the first three chapters of the book 'Domain-Driven Design Quickly' to the repository. The summary includes key concepts such as the definition of software, domain, model, common language, modularization, and cohesion. It also touches upon the importance of communication between developers and domain experts, and the use of models for effective communication.
Highlights
- Domain-Driven Design Concepts: Introduces fundamental concepts of Domain-Driven Design, including software, domain, models, and the importance of a common language between developers and domain experts.
- Modularization and Cohesion: Explains modularization techniques for reducing complexity and different types of cohesion (communicational and functional).
- Discussion Point: Raises a discussion point about experiences with incorrect domain knowledge leading to development challenges.
Changelog
- 2025/Domain-Driven Design Quickly/donghyeon/ch1-2-3.md
- Added a new file summarizing chapters 1-3 of 'Domain-Driven Design Quickly'.
- Included a discussion point about the impact of incorrect domain knowledge.
- Defined key concepts like software, domain, and model in the context of DDD.
- Explained the importance of a common language and modularization.
- Introduced communicational and functional cohesion.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Did you know?
The concept of Domain-Driven Design is not limited to software development; it can also be applied to other fields like business strategy and organizational design.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request adds a summary of chapters 1-2-3 from the book 'Domain-Driven Design Quickly' in Korean. The content seems well-organized and provides a good overview of the key concepts. No style guide was provided, so I will be reviewing the code based on general best practices.
Merge Readiness
The pull request is ready to be merged. The content is well-organized and provides a good overview of the key concepts from the book. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging.
| ## 논의 | ||
|
|
||
| 웃긴 이야기지만 도메인 전문가의 잘못된 지식 때문에 시스템을 완전히 갈아엎은 경험이 있습니다. 이런 사례까지는 아니지만 잘못된 도메인 지식으로 인해 개발에 어려움을 겪은 경험이 있다면 같이 공유해보면 좋을 것 같습니다. |
There was a problem hiding this comment.
도메인의 어떤 부분을 개발자와 PO가 각각 잘못 이해하고 있는 상태에서 개발 하였는데, 이를 배포가 나간이후에 잘못되었다는 것을 알게된 경험이 있긴 하네요
There was a problem hiding this comment.
잘못된 도메인지식을 가진 전문가와 이야기한적은 없었지만
기획문서상에서 논리적으로 이상한점이 있어 이야기했었지만 기획자는 아무이상 없다고 하여 개발하였는데
추후 그 부분을 다시 수정한 경험이 있습니다.
| ## 논의 | ||
|
|
||
| 웃긴 이야기지만 도메인 전문가의 잘못된 지식 때문에 시스템을 완전히 갈아엎은 경험이 있습니다. 이런 사례까지는 아니지만 잘못된 도메인 지식으로 인해 개발에 어려움을 겪은 경험이 있다면 같이 공유해보면 좋을 것 같습니다. |
There was a problem hiding this comment.
잘못된 도메인지식을 가진 전문가와 이야기한적은 없었지만
기획문서상에서 논리적으로 이상한점이 있어 이야기했었지만 기획자는 아무이상 없다고 하여 개발하였는데
추후 그 부분을 다시 수정한 경험이 있습니다.
|
|
||
| ## 논의 | ||
|
|
||
| 웃긴 이야기지만 도메인 전문가의 잘못된 지식 때문에 시스템을 완전히 갈아엎은 경험이 있습니다. 이런 사례까지는 아니지만 잘못된 도메인 지식으로 인해 개발에 어려움을 겪은 경험이 있다면 같이 공유해보면 좋을 것 같습니다. |
There was a problem hiding this comment.
이런 사례가 흔하긴 한가 봅니다 저도 도메인 전문가(라고 얘기하지만 사실 해당 고객사와 미팅을 먼저 해서 정보를 먼저 접한 내부 PM 혹은 영업)
의 얘기를 듣고 만들었는데 데모를 보여주고 나서 많이 바꾼 적이 있었습니다.
그래서 그 다음부터는 오해가 생길 여지가 있는 부분이 있으면 맞는지 고객사 미팅때 확인하는 편이긴 합니다.
가벼운 마음으로 읽기 좋은 책인 것 같습니다. 재밌게 읽었습니다.
close #494