-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
타입으로 견고하게 다형성으로 유연하게 5장 진태영 #492
base: main
Are you sure you want to change the base?
The head ref may contain hidden characters: "\uD0C0\uC785\uC73C\uB85C-\uACAC\uACE0\uD558\uAC8C-\uB2E4\uD615\uC131\uC73C\uB85C-\uC720\uC5F0\uD558\uAC8C-5\uC7A5-\uC9C4\uD0DC\uC601"
Conversation
책 리뷰 및 키워드, 느낀점 추가
느낀점 추가
논의사항 추가
우측에 있는 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @jintaeyeong, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request contains a review of Chapters 4 and 5 from the book '타입으로 견고하게 다형성으로 유연하게' (Robust with Type, Flexible with Polymorphism) by jintaeyeong. The review includes keyword summaries, personal reflections, and discussion points related to the content of each chapter. Chapter 4 focuses on generics, type parameter constraints, and variance (covariance, invariance, and contravariance). Chapter 5 covers overloading, overriding, type classes, and kinds. The author shares their understanding of the concepts, difficulties encountered, and questions for discussion.
Highlights
- Chapter 4 Review: Summarizes key concepts from Chapter 4, including generic classes, type parameter constraints (upper bounds, recursive constraints), and variance (covariance, invariance, contravariance).
- Chapter 5 Review: Summarizes key concepts from Chapter 5, including overloading (function, method, operator), overriding, type classes, and kinds. It also includes a comparison table between overloading and overriding.
- Personal Reflections: The author shares their understanding of generics and type parameter constraints, as well as difficulties in understanding contravariance. They also reflect on the new concepts learned and the broader understanding of polymorphism gained from reading the book.
- Discussion Points: The author raises questions for discussion, such as the practical application of variance annotations (out, in) and the preference between overloading and 'or' types in development.
Changelog
- 2025/RobustWithTypeFlexibleWithPolymorphism/jintaeyeong/4장 두 다형성의 만남.md
- Added a review and keyword summary for Chapter 4.
- Included sections for 느낀점 (personal reflections) and 논의 내용 (discussion points).
- 2025/RobustWithTypeFlexibleWithPolymorphism/jintaeyeong/5장 오버로딩에 의한 다형성.md
- Added a review and keyword summary for Chapter 5.
- Included sections for 느낀점 (personal reflections) and 논의 내용 (discussion points).
- Added a comparison table for 오버로딩 (overloading) and 메서드 오버라이딩 (method overriding).
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Trivia time!
What is the origin of the term 'polymorphism' in computer science?
Click here for the answer
The term 'polymorphism' comes from the Greek words 'poly' (meaning 'many') and 'morph' (meaning 'form'). It was likely adopted to describe the ability of a single interface to represent many forms of data.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request summarizes key concepts from chapters 4 and 5 of the book, focusing on generics, variance, overloading, and overriding. It also includes personal reflections and discussion points. The summaries are well-organized and provide a good overview of the material.
Merge Readiness
The pull request provides a good summary of the chapters and includes thoughtful reflections and discussion points. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging. There are no critical or high severity issues, so the pull request is ready to be merged after addressing the medium severity comments.
2025/RobustWithTypeFlexibleWithPolymorphism/jintaeyeong/5장 오버로딩에 의한 다형성.md
Outdated
Show resolved
Hide resolved
2025/RobustWithTypeFlexibleWithPolymorphism/jintaeyeong/5장 오버로딩에 의한 다형성.md
Outdated
Show resolved
Hide resolved
## 논의사항 | ||
1.오버로딩은 이거나 타입과 비교했을 때 간단한 해결책이라고 적혀있지만 실제로 개발하실 때는 오버로딩과 이거나 타입 중에 어떤 방식을 더 선호하시나요?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
상황에 따라 다르지만, 저는 많은 경우에 일단 이거나 타입으로 일단 작성했었습니다
이후에 오버로딩으로 리팩토링 했었던 걸로 기억이 나네요
…딩에 의한 다형성.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…딩에 의한 다형성.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
타입으로 견고하게 다형성으로 유연하게 첫날 읽을 때는 정적, 동적 언어에 대한 개념부터 시작해서 3,4,5장 페이지를 넘길 수록 어려웠던 부분이 많았던 것 같습니다.
그래도 타입과 다형성이라는 주제로 이야기도 만들어서 최대한 쉽게 이해할 수 있도록 쓰신 것 같습니다.
오버로딩과 오버라이딩에 대한 차이점만 알고 있었지만 책을 읽고 더 확실히 이해하고 사용할 수 있을 것 같습니다!