Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: useLayers setting to manage z-index on dragging #234

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

digitalclubb
Copy link
Contributor

Overview

Adding a setting to manage z-index layering.

Current behaviour will apply a z-index when an item is selected and apply a high z-index when the item has been dragged. This setting would allow users to disable this behaviour so that items retain their original z-index.

Usage:

const ds = new DragSelect({
    selectables: document.getElementsByClassName('item'),
    area: document.getElementById('container'),
    useLayers: false,
})

Type of change

  • Feature - a new component or behaviour has been added
  • 🐛 Fix - fixing a known issue within the codebase
  • ♻️ Chore - maintenance task where behaviour and implementation haven't changed
  • 📝 Docs - updating any README or markdown files

Checklist

  • I have updated the documentation accordingly.
  • I have set the PR title to conventional commit format.
  • I have built any changed GitHub Actions.

Copy link
Owner

@ThibaultJanBeyer ThibaultJanBeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome PR 🌟
Honestly this is the cleanest and most complete PR this library has ever gotten! Will merge and deploy immediately as is once tests have passed, thank you =)

@ThibaultJanBeyer ThibaultJanBeyer merged commit 22f4783 into ThibaultJanBeyer:main Sep 17, 2024
1 check passed
@digitalclubb digitalclubb deleted the feat-useLayers branch September 17, 2024 12:45
@ThibaultJanBeyer
Copy link
Owner

Released in version 3.1.0. Thanks, your contribution is noted & appreciated <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants