Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix messy code when send_file text #131

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bingoohuang
Copy link

No description provided.

Chinese (Simplified) 你好,世界! (Nǐ hǎo, shìjiè!)
Russian Здравствуй, мир! (Zdravstvuy, mir!)
Japanese こんにちは、世界! (Konnichiwa, sekai!)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is unnecessary.

} else {
mime.to_string()
};
resp.headers.set_raw("content-type", vec![content_type.into_bytes()]);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content-type already set in line:923


// 修复中文乱码问题:对于文本类型的文件,明确指定 UTF-8 编码
let content_type = if mime.type_() == "text" {
format!("{}; charset=utf-8", mime)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the type is text, first read the content (at most 512 bytes), and use chardet to detect the encoding.

src/main.rs Outdated
@@ -921,6 +921,15 @@ impl MainHandler {
let mime = mime_types::from_path(path).first_or_octet_stream();
resp.headers
.set_raw("content-type", vec![mime.to_string().into_bytes()]);

// 修复中文乱码问题:对于文本类型的文件,明确指定 UTF-8 编码
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English comment please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants