Skip to content

chore: remove _ from code #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: remove _ from code #120

wants to merge 1 commit into from

Conversation

xudaotutou
Copy link

No description provided.

@TheSpyder
Copy link
Owner

Thanks for this! I'll consider it in the lead-up to 1.0, but I might leave it for the wider API cleanup in version 2. At that point we won't need make methods at all, we can just use records with optional fields.

@TheSpyder TheSpyder mentioned this pull request Jan 16, 2024
Merged
@TheSpyder TheSpyder force-pushed the main branch 5 times, most recently from fe0f2e9 to 7f2cf0a Compare May 22, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spocke spocke Awaiting requested review from spocke spocke is a code owner

@TheSpyder TheSpyder Awaiting requested review from TheSpyder TheSpyder is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xudaotutou @TheSpyder