Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telescope: Deal correctly with empty marks on delete and move up/down #633

Open
wants to merge 1 commit into
base: harpoon2
Choose a base branch
from

Conversation

iserpent
Copy link

@iserpent iserpent commented Oct 2, 2024

Telescope extension breaks when a mark is removed from the middle of the list.
The pull request is to add some more consistency here:

  • Telescope shows only non-empty marks
  • Empty marks are preserved to conform with the initial idea to keep the stable indexes
  • Moving a mark up/down respects the positions of empty marks (in Telescope it appears as if the mark was not moved if it exchanges with the empty mark)

Not fixed:

  • Current selection resets when the view is refreshed after the mark is moved up/down

This pull request is not directly related to the encode/decode issue, but rather complements the functionality. It doesn't depend on the encode/decode related pull requests and can be merged independently.

The empty marks are preserved to conform with the initial idea to keep
the stable indexes for the existing marks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant