Skip to content

use JWT timestamp to validate claims #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

use JWT timestamp to validate claims #181

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d191da
use JWT timestamp to validate claims
lutangar Mar 7, 2023
2b563b8
make use of JWT "leeway" on "not before" and "expiration" date valida…
lutangar Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Provider/Azure.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,10 +349,13 @@ public function validateAccessToken($accessToken)
* @return void
*/
public function validateTokenClaims($tokenClaims) {
$timestamp = \is_null(JWT::$timestamp) ? \time() : JWT::$timestamp;

if ($this->getClientId() != $tokenClaims['aud']) {
throw new \RuntimeException('The client_id / audience is invalid!');
}
if ($tokenClaims['nbf'] > time() || $tokenClaims['exp'] < time()) {

if ($tokenClaims['nbf'] > ($timestamp + JWT::$leeway) || $tokenClaims['exp'] < ($timestamp - JWT::$leeway)) {
// Additional validation is being performed in firebase/JWT itself
throw new \RuntimeException('The id_token is invalid!');
}
Expand Down