wrappers: parse_*: file_name uses same bound as miette #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The three parse functions, `parse_ast`, `parse`, and `parse_with_context` take `file_name` as the first argument. This argument is used to construct `miette::NamedSource`, the `new` constructor of which takes `AsRef<str>`. This change ensures that `miette`'s choice bound is preserved. Unfortunately, `miette` misuses the bound, and clones (to `String`) in library code which is unidiomatic. Perhaps `miette` does not need to clone, and they knew this when writing the function signature? Does a new version of `miette` address this?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
==========================================
+ Coverage 76.26% 76.30% +0.03%
==========================================
Files 15 15
Lines 4272 4279 +7
Branches 4272 4279 +7
==========================================
+ Hits 3258 3265 +7
Misses 872 872
Partials 142 142 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The three parse functions,
parse_ast,parse, andparse_with_contexttakefile_nameas the first argument. This argument is used to constructmiette::NamedSource, thenewconstructor of which takesAsRef<str>. This change ensures thatmiette's choice bound is preserved.Unfortunately,
miettemisuses the bound, and clones (toString) in library code which is unidiomatic. Perhapsmiettedoes not need to clone, and they knew this when writing the function signature?Does a new version ofmietteaddress this?