Add datalab support#136
Conversation
Yes, things are mapped, see for example: So for instance in eLabFTW there are tags. The become
Yes, very much possible, but we decided to not import external data (like fetch the 4 Gb file on the network). |
|
Hi @NicolasCARPi, thanks for the quick response. I'll look into that mapping for fields. I guess my issue with import into datalab is that we would treat every ELN "entry" as a physical sample at the moment rather than something generic -- I'll probably leave import for another day and focus on export for now. |
|
@ml-evs Hello Matthew, think you can update this PR? Otherwise we will close it. |
Thanks for the reminder -- I've just pushed an example from our latest release, hopefully this is ready-for-review now! |
|
CI failures look like an intermittent GitHub issue, but there's still some failing tests locally -- will fix now. |
|
Looks like the only outstanding issue is how we are handling nesting of samples -> files. The generic ro-crate tools all seem to work fine and show each sample as a sub-crate, does .eln have some harsher requirements than this? |
|
Yes there are some more stringent tests: tests/check.py and the function checkParamMetadataJson. It verifies that certain keys exist. The issue seems to be: Does that help? or should I go into your .eln-file? |
|
Yeah, I've replicated that error locally but I'm not sure I understand it -- each file is only there once in the crate and in the metadata so I'm not sure I follow... |
|
In the ro-crate-metadata.json:64, you state that there is a hasPart with an @id; but that @id does not appear anywhere in the file. {
"@id": "./jdb2/",
"@type": "Dataset",
"name": "sodium cobalt oxide made by solid state synthesis (2nd attempt)",
"identifier": "jdb2",
"dateCreated": "2024-02-22T07:19:00",
"hasPart": [
{
"@id": "./jdb2/CG20474_jdb11-2a.xrdml"
}
]
},Same issue a few lines down:83, you state that there is an @id, but that @id does not appear in the file. So the issue is not that an item is double, but that some ids (that you use) do not exist. |
Ahhh, that makes more sense -- the error message is a bit of a red herring but I can fix that on our end this week. |
|
Down to to final issues in local testing: How should I specify multiple authors? I'm trying to set Assume this is something straightforward I'm missing -- can look at the validator code for it directly. |
|
Hey,
|
- Add screenshot and note about relationships - Add example ELN export from demo server - Update datalab example with version and license info, plus remove null dates - Fix several issues (but not all) in datalab example - Fix eln zip naming and other tweaks
ccebd5a to
0cf26f1
Compare
|
Thanks @SteffenBrinckmann, that's super helpful -- I did look for plural authors in schema.org and was surprised not to find something similar -- I've made your other suggested fixes and believe the tests should now pass... I get 7 warnings locally, but these are also present if I remove the datalab folder, so hopefully I haven't made anything worse! |
We are working on
.elnexport for datalab and have a minimal working version (datalab-org/datalab#1371 -- cc @BenjaminCharmes). This PR begins to add our example (copied from the other projects for now) and will let us iterate on support for all of our fields.I had a couple of Q's:
.elnfile import support, given how broadly it can be interpreted? Is it enough to simply store the file, or is there an expectation that entry types will be mapped to the underlying standard of the receiving ELN?Cheers!