Initial stage position #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for #289 - for ax in self.axes... setattr was starting the position for the stage. Switched to None to initialize the attribute, without moving the stage. Booted up a semi synthetic configuration (duplicated original configuration.yml file) so that I could remove most everything but the stages. Couple small things discovered along the way. In auto_redial, called device_type instead of cam_type. SyntheticCamera lacked the attribute calculate_readout_time Removed relative offset positions for stage from configuration file. Next, moving to refactor and cleanup stage code.
PIStage and StageBase cleaned up. Co-Authored-By: Kevin Dean <[email protected]>
Fixed copyright """ -> # Removed any references to inner stage position dictionaries or relative moves as I also did in the Physik and StageBase classes. Co-Authored-By: Kevin Dean <[email protected]>
I am a little nervous about removing this call from report_position(): self.update_position_dictionaries() Given that we only have one position dictionary, I removed this method. Now, I only stay self.create_position_dictionary. And in microscope.py, we call report_position... Just an FYI, in case something is off. I cannot test on this machine. Also added a few things to the initialization that were not provided in the __init__ section. Co-Authored-By: Kevin Dean <[email protected]>
Cleaning up unnecessary items in the configuration file... I think we can get rid of velocity too, but this might actually be useful given some of the other discussions we are having with a continuous scanning acquisition mode. Co-Authored-By: Kevin Dean <[email protected]>
zacsimile
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to address our desire to not have the stage go to a default position every time we boot the software. Previously, when we did this, there was a chance for stage crashing. Issue #289
I tried to clean up the code for the following:
stage_asi.py
stage_base.py
stage_galvo.py
stage_pi.py
stage_synthetic.py
Still need to go through the following:
stage_mcl.py
stage_tl_kcube_inertial.py
stage_sutter.py