You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Missing antiforgery middleware prevents the sample’s pages from loading, and partial refresh results can be treated as fresh, leaving missing stories unretried until the cache expires.
Ports the Hacker News async/await demonstration from MAUI to a Blazor Interactive Server app targeting .NET 11, while preserving separate good and bad practice examples.
Changes:
Adds shared Razor UI, refresh handling, navigation, and runtime-async status.
Removes MAUI pages, view models, platform projects, and native resources.
Updates the SDK, solution configuration, and CI workflows for the web sample.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Low-contrast text falls below WCAG AA requirements, and the error banner’s non-focusable dismiss control prevents keyboard users from reaching or activating it.
Make the error dismiss control keyboard accessible
sample/Components/Layout/MainLayout.razor:20
This dismiss control is a non-focusable span, so keyboard users cannot reach or activate it when the error banner appears. Render a labeled native button instead; it remains compatible with Blazor's .dismiss click handling and provides keyboard activation without relying on the failed circuit.
Darken muted text to meet WCAG AA contrast
sample/wwwroot/app.css:5
The muted text has only about 3.54:1 contrast against the story background (#f6f6ef), and 3.15:1 against the demo-bar background. Story metadata, ranks, and visited titles use this color at normal-text sizes, below the 4.5:1 WCAG AA minimum. Darken the shared color so these labels remain readable on both backgrounds.
Use a high-contrast foreground for the active section
sample/wwwroot/app.css:110
White text on the orange header has only about 2.94:1 contrast. The current section label is normal-sized text (0.82rem), so it falls below the 4.5:1 WCAG AA minimum. Use a dark foreground and distinguish the current section with font weight rather than low-contrast white text.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
CI only builds the sample, leaving its coupled Blazor lifecycle and .NET 11 runtime-async behavior untested; both compiler modes and navigation during an active refresh need interactive validation on the pinned RC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports the sample from MAUI to Blazor and updates the sample to .NET 11