Fixes music tracks changing unexpectedly in some circumstances. #748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just tested it, fixes #739 |
|
In which circunstances, and in which game? |
1 similar comment
|
In which circunstances, and in which game? |
|
This indeed fixes the issue @hazelnot mentioned. But on TD, it take ages to pass the Choose Side screen. The Choose Side screen keeps looping while the audio is on a "playing" state. It checks that by calling |
giulianobelinassi
requested changes
Mar 15, 2022
common/soundio_openal.cpp
Outdated
|
|
||
| return val == AL_PLAYING; | ||
| if (val == AL_PLAYING) { | ||
| DBG_LOG("st->OpenALSource state AL_PLAYING, %d returning true.", index); |
There was a problem hiding this comment.
This floods the terminal with messages. Can we not log it very hard?
There was a problem hiding this comment.
The PR is draft for a reason :D I plan to strip the debug commit once I solve the choose screen issues.
With the buffering fixes, the intro was not detecting the end of the audio sample that announces the chosen side correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.