feat: add Roman numeral conversion#987
Merged
siriak merged 2 commits intoTheAlgorithms:masterfrom Jan 6, 2026
Merged
Conversation
Contributor
Author
|
@siriak, this is ready to be merged. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #987 +/- ##
==========================================
+ Coverage 95.83% 95.84% +0.01%
==========================================
Files 356 357 +1
Lines 23745 23923 +178
==========================================
+ Hits 22755 22928 +173
- Misses 990 995 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds comprehensive Roman numeral conversion functionality to the conversions module, supporting bidirectional conversion between integers and Roman numerals.
LeetCode Problem No. 13: Roman to Integer - This implementation solves the classic conversion problem with additional enhancements.
Implementation Details
The implementation provides two main functions:
roman_to_int(roman: &str) -> Result<u32, String>int_to_roman(number: u32) -> Result<String, String>Algorithm Details
Roman to Integer:
Integer to Roman:
Key Features
Resultfor proper error handlingRoman Numeral Rules
Changes Made
src/conversions/roman_numerals.rswith complete implementationsrc/conversions/mod.rsto include and export the moduleType of Change
Testing
All tests pass successfully:
Test Coverage
✅ 50+ Unit Tests Including:
Examples
Checklist
cargo fmtcargo clippymod.rsAdditional Context
Resulttype for error handling instead of assuming valid inputchar_to_valuehelperAlgorithm Efficiency:
Historical Context:
References