-
-
Notifications
You must be signed in to change notification settings - Fork 46.8k
Update pop function #5544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update pop function #5544
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7402a02
Updated Pop function
limbad-YK 00e0a1b
Update Pop Function
limbad-YK 501af2c
Update stack.py
cclauss 904284b
if not self.stack: raise StackUnderflowError
cclauss 2fe1dc5
Add doctests
cclauss 6efa164
StackUnderflowError
cclauss 91498df
..., not ....
cclauss 0f2bf9a
Update stack.py
cclauss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -4,6 +4,8 @@ | |||||
class StackOverflowError(BaseException): | ||||||
pass | ||||||
|
||||||
class StackUnderflowError(BaseException): | ||||||
pass | ||||||
|
||||||
class Stack: | ||||||
"""A stack is an abstract data type that serves as a collection of | ||||||
|
@@ -32,6 +34,8 @@ def push(self, data): | |||||
|
||||||
def pop(self): | ||||||
"""Pop an element off of the top of the stack.""" | ||||||
if not self.stack: # Condition to check Underflow of stack | ||||||
pass | ||||||
return self.stack.pop() | ||||||
|
||||||
def peek(self): | ||||||
|
@@ -64,6 +68,7 @@ def test_stack() -> None: | |||||
assert stack.is_full() is False | ||||||
assert str(stack) == "[]" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
|
||||||
try: | ||||||
_ = stack.pop() | ||||||
assert False # This should not happen | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.