Fix FuzzySet.union() constructor argument order - #15276
Closed
HarshRajSinghania wants to merge 2 commits into
Closed
Fix FuzzySet.union() constructor argument order#15276HarshRajSinghania wants to merge 2 commits into
HarshRajSinghania wants to merge 2 commits into
Conversation
union() previously called FuzzySet(name, min_left, max_right, avg_peak) while the constructor is (name, left_boundary, peak, right_boundary), so peak and right_boundary were swapped. Fixes TheAlgorithms#11871
Member
|
No files changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Fixes #11871
FuzzySet.union()constructed the result asFuzzySet(name, min_left, max_right, avg_peak), but the constructor is(name, left_boundary, peak, right_boundary). Peak and right boundary were swapped, which is why the existing doctest reported the inconsistentpeak=0.6, right_boundary=0.35.This change passes the arguments in constructor order:
The class-level and method-level union doctests were updated to match the corrected construction. No other methods were changed.
Checklist:
Testing
Result: 22 passed, 0 failed.