Skip to content

Replace assert-based validation with explicit errors in modular_division #14204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaximSmolskiy merged 6 commits into from
Mar 9, 2026
Merged

Replace assert-based validation with explicit errors in modular_division #14204

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
74ba427
Improve documentation for linear search algorithm
Jan 22, 2026
03c60a1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 22, 2026
9d84bf4
Replace asserts with explicit validation in modular_division
Jan 23, 2026
84222da
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 23, 2026
eb99d28
Update linear_search.py
MaximSmolskiy Mar 9, 2026
241ebd1
Merge branch 'master' into fix-modular-division-validation
MaximSmolskiy Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions maths/modular_division.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,13 @@ def modular_division(a: int, b: int, n: int) -> int:
4

"""
assert n > 1
assert a > 0
assert greatest_common_divisor(a, n) == 1
if n <= 1:
raise ValueError("Modulus n must be greater than 1")
if a <= 0:
raise ValueError("Divisor a must be a positive integer")
if greatest_common_divisor(a, n) != 1:
raise ValueError("a and n must be coprime (gcd(a, n) = 1)")

(_d, _t, s) = extended_gcd(n, a) # Implemented below
x = (b * s) % n
return x
Expand Down