Skip to content

Fix Tree Sort algorithm for duplicate values and input types #12786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 53 additions & 41 deletions sorts/tree_sort.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
"""
Tree_sort algorithm.

Build a Binary Search Tree and then iterate thru it to get a sorted list.
"""

from __future__ import annotations

from collections.abc import Iterator
Expand All @@ -12,61 +6,79 @@

@dataclass
class Node:
"""Node of a Binary Search Tree (BST) for sorting."""

val: int
left: Node | None = None
right: Node | None = None

def __iter__(self) -> Iterator[int]:
"""In-order traversal generator for BST."""
# Traverse left subtree first (smaller values)
if self.left:
yield from self.left

# Current node value
yield self.val

# Traverse right subtree last (larger values)
if self.right:
yield from self.right

def __len__(self) -> int:
return sum(1 for _ in self)

def insert(self, val: int) -> None:
if val < self.val:
"""Insert value into BST while maintaining sort order."""
# Values <= current go to left subtree
if val <= self.val:
if self.left is None:
self.left = Node(val)
else:
self.left.insert(val)
elif val > self.val:
if self.right is None:
self.right = Node(val)
else:
self.right.insert(val)
# Values > current go to right subtree
elif self.right is None:
self.right = Node(val)
else:
self.right.insert(val)


def tree_sort(arr: list[int]) -> tuple[int, ...]:
def tree_sort(arr: list[int] | tuple[int, ...]) -> tuple[int, ...]:
"""
>>> tree_sort([])
()
>>> tree_sort((1,))
(1,)
>>> tree_sort((1, 2))
(1, 2)
>>> tree_sort([5, 2, 7])
(2, 5, 7)
>>> tree_sort((5, -4, 9, 2, 7))
(-4, 2, 5, 7, 9)
>>> tree_sort([5, 6, 1, -1, 4, 37, 2, 7])
(-1, 1, 2, 4, 5, 6, 7, 37)

# >>> tree_sort(range(10, -10, -1)) == tuple(sorted(range(10, -10, -1)))
# True
Sort sequence using Binary Search Tree (BST) traversal.

Args:
arr: Input sequence (list or tuple of integers)

Returns:
Tuple of sorted integers

Examples:
>>> tree_sort([])
()
>>> tree_sort((1,))
(1,)
>>> tree_sort((1, 2))
(1, 2)
>>> tree_sort([5, 2, 7])
(2, 5, 7)
>>> tree_sort((5, -4, 9, 2, 7))
(-4, 2, 5, 7, 9)
>>> tree_sort([5, 6, 1, -1, 4, 37, 2, 7])
(-1, 1, 2, 4, 5, 6, 7, 37)
>>> tree_sort([5, 2, 7, 5]) # Test duplicate handling
(2, 5, 5, 7)
"""
if len(arr) == 0:
return tuple(arr)
root = Node(arr[0])
for item in arr[1:]:
root.insert(item)
return tuple(root)
# Handle empty input immediately
if not arr:
return ()

# Convert to list for uniform processing
items = list(arr)

if __name__ == "__main__":
import doctest
# Initialize BST root with first element
root = Node(items[0])

doctest.testmod()
print(f"{tree_sort([5, 6, 1, -1, 4, 37, -3, 7]) = }")
# Insert remaining items into BST
for item in items[1:]:
root.insert(item)

# Convert BST traversal to sorted tuple
return tuple(root)