fix: Multiple versions of Lit loaded #25 #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified package.json files to include lit as peer and devdependencies. modified vite.config.js to prevent Lit from being included in my final build. Reviewed-by: Goulielmos Floros Ref: ThatOpen#25
|
Hey @GoulielmosFloros! Thanks for this PR. If you have set Lit as a peer dependency, then you:
May you update those things, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
modified package.json files to include lit as peer and devdependencies.
modified vite.config.js to prevent Lit from being included in my final build.
Reviewed-by: Goulielmos Floros
Ref: #25
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following:
feat(examples): add hello-world example).fixes #123).