fix: create a selectall checkbox #49 #66
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I removed the if statement that was not allowing a header to get a checkbox. Now when you create your table you can add the command: [yourTableName].selectableRows = true; and the checkboxes will appear. Also, when you click the button in the header it selects and deselects all the subsequent rows. Reviewed-by: Goulielmos Floros Ref: ThatOpen#49
|
Hey @GoulielmosFloros! I was testing this, and it works for the parent-most rows of the table. However, it doesn't work for nested rows 🤔 Are you able to make it work for them as well, please? Thanks a lot! |
…ecursive function to help find all of them.
… a recursive function to loop through every one.
|
Apologies Juan the first commit description had to do with doing the merge and resolving the conflicts, but by mistake I changed the description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I removed the if statement that was not allowing a header to get a checkbox.
Now when you create your table you can add the command: [yourTableName].selectableRows = true;
and the checkboxes will appear.
Also, when you click the button in the header it selects and deselects all the subsequent rows.
Reviewed-by: Goulielmos Floros
Ref: #49
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following:
feat(examples): add hello-world example).fixes #123).