Update OPEN_PRU product version to 2026.01.00#140
Conversation
Code Review by Qodo
Context used✅ Tickets:
🎫 Update OPEN_PRU version from 07.03.01 1. @cliArgs exceeds 129 columns
|
PR Summary by QodoBump OPEN_PRU product version to 2026.01.00 in metadata and SysConfig pins WalkthroughsDescription• Update OPEN_PRU product metadata version from 07.03.01 to 2026.01.00. • Re-pin SysConfig CLI args to OPEN_PRU@2026.01.00 across affected examples. • Leave MCU_PLUS_SDK product pins unchanged to avoid unintended SDK upgrades. Diagramgraph TD
S["SysConfig example.syscfg"] --> T(["SysConfig (GUI/CLI)"]) --> R(["Product resolver"]) --> P[("OPEN_PRU@2026.01.00")]
M[".metadata/product.json"] --> R
T --> C(["CCS import/build"]) --> P
subgraph Legend
direction LR
_f["File"] ~~~ _t(["Tool"]) ~~~ _p[("Product")]
end
High-Level AssessmentThe following are alternative approaches to this PR: 1. Centralize OPEN_PRU version in a shared template
2. Remove explicit OPEN_PRU pin and rely on environment default
Recommendation: For an immediate fix to #108, directly updating the pinned OPEN_PRU version in product.json and the SysConfig headers is the most reliable and least disruptive approach. Longer term, consider templating or generating the SysConfig header pins from a single source of truth to prevent the same drift from recurring, but that’s a broader workflow change than this issue warrants. File ChangesOther (16)
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
|
Must also update docs/tagging_checklist.md to update .metadata/product.json in addition to .metadata/.tirex/package.tirex.json |
nsaulnier-ti
left a comment
nsaulnier-ti
left a comment
There was a problem hiding this comment.
must update docs/tagging_checklist.md
Per maintainer review on PR TexasInstruments#140 (issue TexasInstruments#108): the OPEN_PRU version field lives in both .metadata/.tirex/package.tirex.json and .metadata/product.json. Update the tagging checklist so future tags bump both files, not just the tirex package descriptor.
|
@nsaulnier-ti good catch — done in f66c7fd. The Update the .metadata version section of This matches the actual version edits in this PR, so future tags won't miss |
The OPEN_PRU product version was stale at 07.03.01 in product.json and in every SysConfig file pinning the OPEN_PRU product. Bump all of them to the 2026.01.00 release version so SysConfig product resolution and CCS imports reference the correct product. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Per maintainer review on PR TexasInstruments#140 (issue TexasInstruments#108): the OPEN_PRU version field lives in both .metadata/.tirex/package.tirex.json and .metadata/product.json. Update the tagging checklist so future tags bump both files, not just the tirex package descriptor.
nsaulnier-ti
force-pushed
the
fix/issue-108-open-pru-version
branch
from
f66c7fd to
5fcebbc
Compare
The column-length best practices (79 soft / 129 hard) were written for hand-authored source. SysConfig example.syscfg files are machine- generated: their @cliArgs/@v2CliArgs header lines are single-line command strings that exceed column 129 by construction and cannot be wrapped without breaking the tool's round-trip. Treating those lines as violations produces false-positive review flags on any PR that touches a .syscfg file (for example the OPEN_PRU version bump in #108/#140, which only edited a token inside pre-existing long lines). Make the exemption explicit, consistent with the existing markdown/.txt carve-out, so automated and human reviewers stop flagging generated content.
3 participants
Fixes #108
The OPEN_PRU product version was stale at
07.03.01. This updates it to the2026.01.00release version in the two places the issue identifies:.metadata/product.json—versionfield--product OPEN_PRU@<ver>pin in@cliArgs/@v2CliArgsOnly the
OPEN_PRU@product version is changed;MCU_PLUS_SDK@07.03.01is intentionally left untouched (separate product, out of scope for this issue).16 files changed, version-string-only edits.
CI: all three workflows (Makefile CI, GNU Toolchain CI, CCS Build — full device matrix) pass on this change on my fork.