Fixed flaky test in 'twitter/GraphJet' repository.#737
Merged
darko-marinov merged 1 commit intoTestingResearchIllinois:mainfrom Mar 27, 2023
Merged
Fixed flaky test in 'twitter/GraphJet' repository.#737darko-marinov merged 1 commit intoTestingResearchIllinois:mainfrom
darko-marinov merged 1 commit intoTestingResearchIllinois:mainfrom
Conversation
Contributing fix for 'testSalsaWithRandomGraph' flaky test(#5028), PR is created, which hasn't yet been accepted by developers.
Contributor
|
Thanks for your changes. Did you work with anyone to prepare the PR to the developers? |
Contributor
Author
|
Professor Darko Marinov(@darko-marinov ) provided supervision during the process of finding and fixing the flakiness of the test and then preparing the PR. I completed the work independently. If you have any further questions or concerns, please feel free to ask. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributing fix for 'testSalsaWithRandomGraph' flaky test(#5028), PR is created, which hasn't yet been accepted by developers.
testSalsaWithRandomGraph flaky test is fixed in twitter in the GraphJet module.
Here is the twitter/GraphJet#138 that was opened to fix the flaky test.
The following changes were made to pr-data.csv in this PR:
Flaky test
twitter.graphjet.algorithms.salsa.SalsaTest.testSalsaWithRandomGraphwas already in pr-data.csv, I updated the line for this flaky test to include the fix PR link and set the status to 'opened.'