Touch buttons #1164
Open
Touch buttons #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NyakoFox
force-pushed
the
touch-buttons
branch
2 times, most recently
from
27b22b2 to
ac421d9
Compare
This commit adds virtual buttons on-screen to let you navigate through menus, and play the game.
Touch input automatically "disables" when you press a key on your keyboard. The back button on Android counts as a key press, so let's just ignore it.
For some reason, the code that handled button presses for the ingame menu checked the confirm button in the wrong places.
Basically, when you save and quit, if you have a save, it attempts to return to the `play` menu. Unfortunately for us, if you don't have a save first, that menu never existed. You went directly from `mainmenu` to the gameplay state. Since `play` never existed, the code didn't have any menu to return to, so no buttons got created. My fix is simple: if the menu isn't found, just make it.
NyakoFox
force-pushed
the
touch-buttons
branch
from
ac421d9 to
9f9c813
Compare
NyakoFox
force-pushed
the
touch-buttons
branch
from
e6753ac to
30abc8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This PR adds a dynamic menu button system, removing the need to use a dpad control scheme for menus. It goes through most menus and redesigns them to work well with touch buttons, most being manually positioned. It contains a system for dynamically creating buttons based off of a menu as well.
Limitations:
Depends on #1160.
Legal Stuff:
By submitting this pull request, I confirm that...
CONTRIBUTORSfile and the "GitHub Friends"section of the credits for all of said releases, but will NOT be compensated
for these changes unless there is a prior written agreement