Added ConstantContact Provider #193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TerribleDev
requested changes
Nov 29, 2016
|
|
||
| namespace Owin.Security.Providers.ConstantContact | ||
| { | ||
| public class Class1 |
There was a problem hiding this comment.
Can you please delete this file that does nothing?
| }; | ||
| if (!string.IsNullOrEmpty(context.AccessToken)) | ||
| { | ||
| context.Identity.AddClaim(new Claim(ClaimTypes.NameIdentifier, context.AccessToken, XmlSchemaString, Options.AuthenticationType)); |
There was a problem hiding this comment.
I don't believe any of the providers in this repository place their access tokens right in the users claims. If people wish to get access to these tokens they can pass in their own AuthenticationProvider with its own OnAuthenticated lambda
| : base("ConstantContact") | ||
| { | ||
| Caption = Constants.DefaultAuthenticationType; | ||
| CallbackPath = new PathString("/signin-ConstantContact"); |
There was a problem hiding this comment.
can you make the path string all lower case?
There was a problem hiding this comment.
and then fix the comment on the parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constant Contact Oauth 2 provider