Remove redundant stack trace printing for icon errors #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm often in the situation where I'm developing a new mod that doesn't have an icon yet. I use Mod Menu to access my config file, and it prints a large stack trace twice. Once when entering, and once when exiting. Since there is already a complete error line in red, which is acceptable to be shown I think, there is no need for a multi-line stack trace after that. I've removed it for the square icon error as well, since that feels redundant too. But I can re-add that, let me know. Thanks for the great mod!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm often in the situation where I'm developing a new mod that doesn't have an icon yet. I use Mod Menu to access my config file, and it prints a large stack trace twice. Once when entering, and once when exiting.
Since there is already a complete error line in red, which is acceptable to be shown I think, there is no need for a multi-line stack trace after that.
I've removed it for the non-square icon error as well, since that feels redundant too. But I can re-add that, let me know.
Thanks for the great mod!