feat: User 模型添加 time_zone 字段 #244
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xogas
force-pushed
the
feat/bkpaas_auth-add-time-zone
branch
from
6ec8a35 to
feda41a
Compare
nannan00
reviewed
Nov 28, 2025
|
|
||
| def _create_authenticated_user( | ||
| self, username: str, provider_type: ProviderType, tenant_id: str | None = None | ||
| self, username: str, provider_type: ProviderType, time_zone: str | None = None, tenant_id: str | None = None |
Contributor
There was a problem hiding this comment.
APIGatewayAuthBackend 似乎与用户 time_zone 无关，网关JWT 里不会传递用户 time_zone
下同
jiayuan929
reviewed
Dec 2, 2025
piglei
reviewed
Dec 3, 2025
| "data": { | ||
| "bk_username": settings.USER_NAME, | ||
| "LoginName": settings.USER_NAME, | ||
| "ChineseName": settings.USER_NICKNAME, |
Collaborator
There was a problem hiding this comment.
从使用者的角度，这个 SDK 有必要提供其他和用户时区相关的 methods/functions，来让功能更易用吗？
There was a problem hiding this comment.
Pull request overview
This PR adds a time_zone field to the User model in the bkpaas-auth SDK, enabling user timezone information to be retrieved from authentication APIs and stored in user objects. The implementation follows the existing pattern used for the tenant_id field, treating time_zone as an optional field that defaults to None when not provided by the API.
Key changes:
- Added
time_zoneas an optional field throughout the authentication flow (UserAccount, UserInfo, User model) - Updated test fixtures and added comprehensive test coverage for both presence and absence of the field
- Modified function signature defaults in
APIGatewayAuthBackend.authenticate_with_signature_v3
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
bkpaas_auth/models.py |
Added time_zone to USERINFO_FIELDS tuple for dynamic field population |
bkpaas_auth/core/user_info.py |
Added time_zone extraction from kwargs in UserInfo.__init__ |
bkpaas_auth/core/token.py |
Added time_zone field to UserAccount NamedTuple with documentation; updated _request_apigw to extract time_zone from API response |
bkpaas_auth/backends.py |
Passed time_zone to UserInfo in authentication flow; added default values to authenticate_with_signature_v3 parameters |
tests/conftest.py |
Updated get_rtx_user_info_response fixture to include time_zone; added new fixture get_rtx_user_info_response_without_time_zone |
tests/test_models.py |
Added assertions for time_zone field; added new test test_user_info_without_time_zone to verify graceful handling of missing field |
tests/test_backends.py |
Added time_zone assertion to tenant mode test; added new test test_authenticate_bk_token_for_tenant_mode_without_time_zone for missing field scenario |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.