Skip to content

bugfix #1648 #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

bugfix #1648 #1649

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04f91b1
Merge pull request #2 from Tencent/dev
yanbober Apr 26, 2022
98b2da3
fixbug #1648 Groovy read Manifest application name is null.
yanbober Apr 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions ...dle-plugin/src/main/groovy/com/tencent/tinker/build/gradle/task/TinkerManifestTask.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,15 +127,12 @@ public class TinkerManifestTask extends DefaultTask {
def isr = null
try {
isr = new InputStreamReader(new FileInputStream(manifestPath), "utf-8")
def xml = new XmlParser().parse(isr)
def ns = new Namespace("http://schemas.android.com/apk/res/android", "android")

def application = xml.application[0]
if (application) {
return application.attributes()[ns.name]
} else {
return null
}
def result = new XmlSlurper().parse(isr)
def namespaceMap = new HashMap()
namespaceMap.put("android", "http://schemas.android.com/apk/res/android")
result.declareNamespace(namespaceMap)
def applicationName = result.application.@"android:name".text()
return applicationName.length() > 0 ? applicationName : null
} finally {
IOHelper.closeQuietly(isr)
}
Expand Down