fix(Dialog): destroyOnClose 为 true 时 onBeforeOpen 事件重复触发的问题 #5449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l123wx
requested review from
PengYYYYY,
chaishi,
uyarn,
zhangpaopao0609,
liweijie0812,
Cat1007 and
Wesley-0808
as code owners
|
destroyOnClose 的本意是在 dialog 关闭时销毁 dialog 的子元素，所以把原来整个 dialog 都销毁的逻辑改成了只销毁 子元素。isDialogClosed 用于避免 visible = false 时子元素马上被销毁出现闪烁的情况 |
TDesign Component Site Preview Open
|
commit: |
uyarn
approved these changes
May 19, 2025
uyarn
approved these changes
May 19, 2025
|
重新验证了下 https://stackblitz.com/edit/arxhzckq-adqpd4nd?file=src%2FDemo.vue 二次打开会还是会有多次触发的情况 |
看了一下是 dev 合进来的代码改了部分逻辑，我改一下 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
#4835
💡 需求背景和解决方案
📝 更新日志
tdesign-vue-next
@tdesign-vue-next/chat
☑️ 请求合并前的自查清单