fix(MessagePlugin): improve container management #3820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RylanBot
requested review from
honkinglin,
uyarn,
carolin913,
HaixingOoO,
NWYLZW and
ZWkang
as code owners
|
|
RylanBot
force-pushed
the
rylan/fix/message/container
branch
from
2caea0d to
73affb9
Compare
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
复现链接：https://stackblitz.com/edit/mbnapcc5?file=src%2Fdemo.tsx
💡 需求背景和解决方案
const MessageContainerMaps: Map<HTMLElement, Map<MessagePlacementList, ContainerInstance>> = new Map();，容器的读取完全借助该Map，不需要query节点📝 更新日志
fix(MessagePlugin): 修复自定义
attach后，后续其它全局消息也被绑定到该节点中的异常refactor(MessagePlugin): 移除消息容器的⚠️
id='tdesign-message-container--${placement}'，之前依赖该属性的业务注意此变更本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单