sequence: fix bug when first partition vertices < 4096#64
Open
lorinlee wants to merge 1 commit intoTencent:masterfrom
Open
sequence: fix bug when first partition vertices < 4096#64lorinlee wants to merge 1 commit intoTencent:masterfrom
lorinlee wants to merge 1 commit intoTencent:masterfrom
Conversation
lorinlee
commented
Mar 4, 2020
lorinlee
commented
- When first partition's vertices size less than 4096, this alignment will cause poffset(1) = 0, and the next loop will start from v_i = 0 again. Finally, the partition offsets are [0, 0), [0, 0), [0, 0) ...
- this alignment modifies offset, but not adjust amount
- Why need this alignment ?
|
cc @xuguruogu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.