Fix infinite GIF reader loop on zero-frame streams - #2315
Open
XXcipherX wants to merge 1 commit into
Open
Conversation
Stop reopening an FFmpeg reader that reaches EOF before producing a frame, preventing repeated synchronous decoding. Fixes TelegramMessenger#2246
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BatchVideoRenderingContextrepeatedly reopened an FFmpeg reader when a stream reached EOF without producing any frames. This caused a synchronous decoding loop, sustained CPU usage, and blocked GIF rendering.Track whether the reader has produced a frame. Restart it only after it has produced at least one frame; treat zero-frame EOF as a decoding failure.
Testing
Verified with the focused
BatchVideoRenderingTestsregression harness on GitHub Actions using Xcode 26.2 and iOS 26.2:https://github.com/XXcipherX/telegram-ios-gif-regression-test/actions/runs/33513158372
Fixes #2246