Fayra/update sim swap #68
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegotid
reviewed
Feb 25, 2025
There was a problem hiding this comment.
I don't think this page needs a change. If it did, I think the problem is the opposite, and we should make the developer portal contents more technical, not a different version of the product description in the marketing website, which involved a lot of work from product managers.
In addition, there are style issues and English typos
- RETRIVE is "Retrieve"
- SIM vs Sim case is inconsistent
- "SIM card number changed" is inaccurate and confusing
- Response bodies are not to be included here since we have API references
diegotid
force-pushed
the
main
branch
8 times, most recently
from
22d8fab to
cac0a3c
Compare
diegotid
force-pushed
the
main
branch
15 times, most recently
from
0ff0c5a to
7b92209
Compare
diegotid
force-pushed
the
main
branch
2 times, most recently
from
c83fb18 to
57990ff
Compare
diegotid
force-pushed
the
main
branch
6 times, most recently
from
df2c1ff to
7a09522
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the sim swap page with general information per endpoint