Skip to content

Skin Tool with index, onboarding and first advanced tools #2078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: mistica-design-site
Choose a base branch
from

Conversation

marinitx
Copy link

First version of the SkinTool, an intuitive tool for creating and previewing custom brand skins efficiently using Mística.

@marinitx marinitx requested a review from aweell February 26, 2025 13:46
@yceballost yceballost requested a review from Copilot April 11, 2025 20:20
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 22 out of 27 changed files in this pull request and generated 1 comment.

Files not reviewed (5)
  • package.json: Language not supported
  • src/pages/skin-tool/advanced-tools.css: Language not supported
  • src/pages/skin-tool/fonts/fonts.css: Language not supported
  • src/pages/skin-tool/onboarding/create-color.css: Language not supported
  • src/pages/skin-tool/onboarding/create-typo.css: Language not supported
Comments suppressed due to low confidence (2)

src/pages/skin-tool/utils/storageUtils.js:86

  • [nitpick] Clarify the comment regarding whether the final skin configuration should include the full palette or a subset of colors to avoid confusion.
// Should return the rest of color variables or only the ones skin tool lets you choose?

src/pages/skin-tool/onboarding/create-border.jsx:113

  • Ensure that getInitialBorderIndex correctly handles cases where savedRadius is not found (findIndex returns -1) instead of defaulting to 0 via logical OR.
const getInitialBorderIndex = () => { const savedRadius = borderConfig.radius; return borderRadiusValues.findIndex(value => value === savedRadius) || 0; };

// Function to reset all the colors to their initial empty state
const handleResetColors = () => {
setColors(initialColors);
localStorage.setItem('userColors', JSON.stringify(initialColors));
Copy link
Preview

Copilot AI Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reset function is using the key 'userColors' while the rest of the code uses 'skinColors'. Update the key to 'skinColors' for consistency.

Suggested change
localStorage.setItem('userColors', JSON.stringify(initialColors));
localStorage.setItem('skinColors', JSON.stringify(initialColors));

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant