Copilot/custom breaking changes #473
Conversation
|
[Firebase] 📱 New catalog for testing generated: |
There was a problem hiding this comment.
Pull request overview
This PR renames a button style enum value and a parameter name. The changes rename PRIMARY_SMALL to PRIMAY_VERY_SMALL (with a typo) across the codebase, modify a tag height, and rename a parameter in PasswordInput.
Key Changes:
- Renamed
ButtonStyle.PRIMARY_SMALLtoButtonStyle.PRIMAY_VERY_SMALLacross all usages - Changed tag height from 28.dp to 42.dp
- Renamed
onClickparameter toonClickActioninPasswordInput
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| library/src/main/java/com/telefonica/mistica/compose/button/Button.kt | Renamed enum value PRIMARY_SMALL to PRIMAY_VERY_SMALL |
| library/src/main/java/com/telefonica/mistica/compose/button/ButtonStyles.kt | Updated button style mapping to use renamed enum |
| library/src/main/java/com/telefonica/mistica/compose/button/ButtonSizes.kt | Updated button size configuration to use renamed enum |
| library/src/main/java/com/telefonica/mistica/button2/Button.kt | Updated XML attribute mapping to use renamed enum |
| library/src/main/java/com/telefonica/mistica/compose/card/Card.kt | Updated CardActions to use renamed button style |
| library/src/main/java/com/telefonica/mistica/compose/callout/Callout.kt | Updated callout primary button to use renamed style |
| library/src/main/java/com/telefonica/mistica/compose/card/highlightedcard/HighLightedCard.kt | Updated style transformation logic to use renamed enum |
| library/src/main/java/com/telefonica/mistica/compose/input/PasswordInput.kt | Renamed onClick parameter to onClickAction |
| library/src/main/java/com/telefonica/mistica/compose/tag/Tag.kt | Changed tag height from 28.dp to 42.dp |
| library/src/test/java/com/telefonica/mistica/button/ButtonTest.kt | Updated test to use renamed button style |
| catalog/src/main/java/com/telefonica/mistica/catalog/ui/compose/components/Inputs.kt | Updated catalog examples to use renamed button style |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| enum class ButtonStyle { | ||
| PRIMARY, | ||
| PRIMARY_SMALL, | ||
| PRIMAY_VERY_SMALL, |
There was a problem hiding this comment.
Corrected spelling of 'PRIMAY_VERY_SMALL' to 'PRIMARY_VERY_SMALL'.
| enum class ButtonStyle { | ||
| PRIMARY, | ||
| PRIMARY_SMALL, | ||
| PRIMAY_VERY_SMALL, |
There was a problem hiding this comment.
This is a breaking change. The enum value PRIMARY_SMALL has been removed and replaced with PRIMAY_VERY_SMALL (note the typo). This will break existing consumers who reference ButtonStyle.PRIMARY_SMALL. Please apply the 'Breaking change' label to this PR and remember to include migration notes when drafting the release.
| enabled: Boolean = true, | ||
| readOnly: Boolean = false, | ||
| onClick: (() -> Unit)? = null, | ||
| onClickAction: (() -> Unit)? = null, |
There was a problem hiding this comment.
This is a breaking change. The parameter name has been changed from onClick to onClickAction, which will break existing consumers using named parameters. Please apply the 'Breaking change' label to this PR and remember to include migration notes when drafting the release.
| .wrapContentSize() | ||
| .defaultMinSize(minWidth = 48.dp) | ||
| .height(28.dp), | ||
| .height(42.dp), |
There was a problem hiding this comment.
This is a breaking change. The tag height has been modified from 28.dp to 42.dp, which changes the visual contract and may break layouts or UI tests that depend on the previous size. Please apply the 'Breaking change' label to this PR and remember to include migration notes when drafting the release.
…ComponentValueComposeFragment
|
[Firebase] 📱 New catalog for testing generated: |
…ttonClick --> onPrimaryButtonClickAction
|
[Firebase] 📱 New catalog for testing generated: |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import com.telefonica.mistica.compose.theme.brand.Brand | ||
|
|
||
| class ComponentComposeFragment(private val theme: Brand, private val component: @Composable () -> Unit) : Fragment() { | ||
| class ComponentValueComposeFragment(private val theme: Brand, private val component: @Composable () -> Unit) : Fragment() { |
There was a problem hiding this comment.
Breaking Change Detected: The class has been renamed from ComponentComposeFragment to ComponentValueComposeFragment. This is a breaking change for any code that references this class. Please apply the 'Breaking change' label to this PR. Migration notes should be added when drafting the release.
🥅 What's the goal?
Provide a description of the overall goal. The description in the Jira ticket may help.
🚧 How do we do it?
Provide a description of the implementation. A list of steps would be ideal.
☑️ Checks
🧪 How can I test this?
If it cannot be tested explain why.